Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client metadata #19

Merged
merged 12 commits into from
Feb 9, 2024
Merged

Client metadata #19

merged 12 commits into from
Feb 9, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Feb 9, 2024

Methods to interact with Socket::data

getData() and setData() imply an optional type argument for ensuring the internal constraints on the metadata type.
The returns of getData() are Optional<> because initially it can be empty.

@RobinTail RobinTail added the enhancement New feature or request label Feb 9, 2024
@RobinTail RobinTail marked this pull request as ready for review February 9, 2024 18:02
src/action.ts Outdated Show resolved Hide resolved
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail merged commit be42031 into main Feb 9, 2024
6 checks passed
@RobinTail RobinTail deleted the client-data branch February 9, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant