Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handler: client, getAllClients, getAllRooms and withRooms().getClients() #16

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Handler: client, getAllClients, getAllRooms and withRooms().getClients() #16

merged 3 commits into from
Feb 8, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Feb 8, 2024 •
edited
Loading

  • moving the current socket features to client argument,
    • renaming socketId to client.id,
  • adding getClients() to withRooms(),
  • adding getAllClients() and getAllRooms()

@RobinTail RobinTail added enhancement New feature or request refactoring labels Feb 8, 2024
@RobinTail RobinTail marked this pull request as ready for review February 8, 2024 21:23
RobinTail
RobinTail commented Feb 8, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail merged commit da21cec into main Feb 8, 2024
6 checks passed
@RobinTail RobinTail deleted the int-client branch February 8, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail