V2 addon format and switch to pnpm, change localization and styles setup #1911

AmauryD · 2023-11-16T07:46:43Z

Related issue: #1910
@RobbieTheWagner I began to work on this, but this will be a breaking change:

treeFor, treeForAddon, treeForAddonTemplates, treeForAddonTestSupport, treeForApp, treeForPublic, treeForStyles, treeForTemplates, treeForTestSupport, treeForVendor: Dropped. Dynamically generating broccoli trees at app build time is no longer supported. Your trees are built at publication time. If you need to produce different output at build time based on dynamic configuration, see Build-time Conditionals.

The theme and language part of flatpickr will be impacted.

RobbieTheWagner · 2023-11-16T16:39:34Z

@AmauryD yeah, we will need to tell people to import the themes and languages directly, which I think is fine.

RobbieTheWagner · 2023-11-16T16:40:37Z

Maybe flatpickr should be be a peerDep as well, so people ship all their own flatpickr stuff, but we provide the components on top.

AmauryD · 2023-11-17T11:49:24Z

@AmauryD yeah, we will need to tell people to import the themes and languages directly, which I think is fine.

Maybe flatpickr should be be a peerDep as well, so people ship all their own flatpickr stuff, but we provide the components on top.

I agree, let's do this !

AmauryD · 2023-11-17T22:40:49Z

@RobbieTheWagner I'm having a hard time figuring how to tell the user to import themes/default locales correctly. Does this seems ok to you ? https://github.com/shipshapecode/ember-flatpickr/blob/8ea4e52ba814e3ace92eff85077f5c0d626f9c16/test-app/app/templates/docs/usage.md
I only made the theme import work by using a js import. Didn't seems to work from the css stylesheet.

AmauryD · 2023-11-25T11:29:29Z

I'm currently testing this PR in one of my company's project. Seems to be working fine. Just some documentation to finish and it's ready.

RobbieTheWagner · 2023-12-12T15:08:38Z

@AmauryD what's the status on this?

AmauryD · 2023-12-13T21:56:48Z

@RobbieTheWagner should be ready for review !

RobbieTheWagner · 2023-12-14T13:35:27Z

.github/workflows/ci.yml

  automerge:
-    needs: [test, floating, try-scenarios]


@AmauryD can we add back the ember-try scenarios please?

is it necessary ? It's already tested by the test command. https://github.com/AmauryD/ember-flatpickr/blob/main/test-app/config/ember-try.js

https://github.com/AmauryD/ember-flatpickr/blob/6afd587d5806042b123cfe44531b398cede8485c/test-app/package.json#L35

The ember-try setup should remain as close to how it was before as possible for ease of upgrading.

Also, I don't know if it runs in CI at all now. We want each try scenario to be a separate run so we can see which ones pass and fail.

I understand. I'll fix this after work 😄
Thank's for the feedback by the way

Thank you for all your hard work on this!

The scenarios are back !

RobbieTheWagner · 2023-12-14T13:36:58Z

.gitignore


 # misc
-/.env*


I think pretty much everything should stay as it was in this file and the old contents should be copied to the new ember-flatpickr folder, I think, to ensure the right things are ignored. Especially stuff like ember-try, which we want to keep.

Just to be sure, you prefer to keep the original content of this file at the project root ?

AmauryD · 2023-12-18T21:37:54Z

Downgraded test helpers from 3.x to 2.x to pass compatibility of ember-lts-4.4

patches/[email protected]

test-app/.prettierignore

test-app/.stylelintignore

AmauryD · 2023-12-25T10:56:32Z

Merry PR Chistmas 🎅 ⛄

test-app/app/templates/flatpickr-test.hbs

RobbieTheWagner · 2023-12-27T00:31:44Z

test-app/app/templates/docs/index.md

+yarn add -D flatpickr
+```
+
+### Default style


Should we mention themes or is that mentioned elsewhere?

There's a brief section on this page: https://github.com/RobbieTheWagner/ember-flatpickr/blob/2b148eb050bbce62026f38dcf108ca085bcf49a5/test-app/app/templates/docs/usage.md#themes

RobbieTheWagner

Awesome work, thank you! There might be a few things we need to document a bit more, but I want to merge this so we don't keep getting conflicts.

AmauryD · 2024-01-09T08:18:17Z

Awesome work, thank you! There might be a few things we need to document a bit more, but I want to merge this so we don't keep getting conflicts.

You're welcome ! It was a pleasure ! 😄

AmauryD force-pushed the main branch from d950977 to 5de72cd Compare November 17, 2023 16:34

AmauryD closed this Nov 17, 2023

AmauryD force-pushed the main branch from 5de72cd to d0cba5d Compare November 17, 2023 16:35

AmauryD reopened this Nov 17, 2023

AmauryD force-pushed the main branch from 71828be to 8258175 Compare November 17, 2023 21:33

AmauryD mentioned this pull request Nov 18, 2023

Error from ember data with the module model ember-learn/ember-cli-addon-docs#1507

Closed

AmauryD force-pushed the main branch from 8ea4e52 to 3a7348f Compare November 21, 2023 19:44

AmauryD marked this pull request as ready for review November 25, 2023 12:26

AmauryD force-pushed the main branch from 8631978 to 68fd3ef Compare December 13, 2023 21:29

RobbieTheWagner reviewed Dec 14, 2023

View reviewed changes

AmauryD added 7 commits December 18, 2023 16:33

move to V2 format

74dad6e

simplify CI - ember-try already included

283d3c1

begin work on documentation

8922d22

css usage

e602ce4

don't include all languages by default

80b90a8

stylelint css

f593b09

installing missing peerDep

f993b3b

AmauryD force-pushed the main branch from 9c25ac8 to a13da48 Compare December 18, 2023 15:34

try-scenarios

572cbf0

AmauryD force-pushed the main branch from a13da48 to 572cbf0 Compare December 18, 2023 15:40

AmauryD added 2 commits December 18, 2023 17:30

support for ember 4.8 and 4.4 is back

4322dd1

downgrade test helpers to pass ember-source 4.4 test

cfd6893

AmauryD force-pushed the main branch from 96fd0ae to cfd6893 Compare December 18, 2023 21:32

add lts 4.12 to CI

d03399a

AmauryD force-pushed the main branch from 26fdbf9 to d03399a Compare December 18, 2023 21:39

RobbieTheWagner reviewed Dec 19, 2023

View reviewed changes

patches/[email protected] Outdated Show resolved Hide resolved

RobbieTheWagner reviewed Dec 19, 2023

View reviewed changes

test-app/.prettierignore Show resolved Hide resolved

RobbieTheWagner reviewed Dec 19, 2023

View reviewed changes

test-app/.stylelintignore Show resolved Hide resolved

AmauryD added 3 commits December 25, 2023 11:21

upgrade ember-cli-addon-docs to v7

03687b5

merge from dependabot

6d72eff

remove duplicates in gitignore

b2865d1

merge from dependabot

2b148eb

RobbieTheWagner reviewed Dec 27, 2023

View reviewed changes

test-app/app/templates/flatpickr-test.hbs Outdated Show resolved Hide resolved

RobbieTheWagner reviewed Dec 27, 2023

View reviewed changes

removing leftover

1a0ab29

RobbieTheWagner added the breaking label Jan 8, 2024

RobbieTheWagner changed the title ~~V2 Addon format and switch to pnpm~~ V2 addon format and switch to pnpm, change localization and styles setup Jan 8, 2024

RobbieTheWagner approved these changes Jan 8, 2024

View reviewed changes

RobbieTheWagner merged commit 8377a03 into RobbieTheWagner:main Jan 8, 2024
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V2 addon format and switch to pnpm, change localization and styles setup #1911

V2 addon format and switch to pnpm, change localization and styles setup #1911

AmauryD commented Nov 16, 2023 •

edited

Loading

RobbieTheWagner commented Nov 16, 2023

RobbieTheWagner commented Nov 16, 2023

AmauryD commented Nov 17, 2023

AmauryD commented Nov 17, 2023 •

edited

Loading

AmauryD commented Nov 25, 2023

RobbieTheWagner commented Dec 12, 2023

AmauryD commented Dec 13, 2023

RobbieTheWagner Dec 14, 2023

AmauryD Dec 14, 2023

RobbieTheWagner Dec 14, 2023

RobbieTheWagner Dec 14, 2023

AmauryD Dec 14, 2023 •

edited

Loading

RobbieTheWagner Dec 14, 2023

AmauryD Dec 25, 2023

RobbieTheWagner Dec 14, 2023

AmauryD Dec 25, 2023

AmauryD commented Dec 18, 2023

AmauryD commented Dec 25, 2023

RobbieTheWagner Dec 27, 2023

AmauryD Dec 27, 2023

RobbieTheWagner left a comment

AmauryD commented Jan 9, 2024


		# misc
		/.env*

V2 addon format and switch to pnpm, change localization and styles setup #1911

V2 addon format and switch to pnpm, change localization and styles setup #1911

Conversation

AmauryD commented Nov 16, 2023 • edited Loading

RobbieTheWagner commented Nov 16, 2023

RobbieTheWagner commented Nov 16, 2023

AmauryD commented Nov 17, 2023

AmauryD commented Nov 17, 2023 • edited Loading

AmauryD commented Nov 25, 2023

RobbieTheWagner commented Dec 12, 2023

AmauryD commented Dec 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AmauryD Dec 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AmauryD commented Dec 18, 2023

AmauryD commented Dec 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RobbieTheWagner left a comment

Choose a reason for hiding this comment

AmauryD commented Jan 9, 2024

AmauryD commented Nov 16, 2023 •

edited

Loading

AmauryD commented Nov 17, 2023 •

edited

Loading

AmauryD Dec 14, 2023 •

edited

Loading