Send multiple message over same TCP connection #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Send multiple message over same TCP connection * Refactor, get rid of uncessary for loop * Remove unused code
|
Thanks, I appreciate the contribution. I'll get onto merging this when I have some free time. |
|
Is this feature is available now ? |
|
Hi. When I tested the PR it didn't work for me. I started looking into a different approach that should have been more efficient but ran out of free time to work on this. My weekends are fully committed with household projects at the moment, and likely to be that way for the next 3 months or so. I'll take a look whenever I have free time to dedicate to this, but at this stage it might take a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the ability to send multiple HL7 messages over a persistent TCP connection, which is closed when the ack for the last message sent is received. This is found in the 'SendMultipleMessages' command.
The messages are rendered onto the 'SendHl7MessageWebView' as a single string, and then the same logic used to extract multiple messages in the 'SplitBatchFile' command is used to extract the separate messages from this string into a string array. Each subsequent message is sent over the same TCP connection once an ack is received for the previously sent message, and we use an increment to keep track of the message being processed. Once we reach the end of the array and an ack is received for the last message in the array sent, we close the connection.