fix use nil parameter, the MinMaxBig func will throw panic's problem #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also look at CompareBigValue ad well?
El mié, 30 de oct de 2024, 8:15 p. m., ChicChip ***@***.***>
escribió:
… i fixed fix use nil parameter, the MinMaxBig func will throw panic's
problem (#455 <#455>)
------------------------------
You can view, comment on, or merge this pull request online at:
#456
Commit Summary
- 32dbf71
<32dbf71>
fix use nil parameter, the MinMaxBig func will throw panic's problem
File Changes
(2 files <https://github.com/RoaringBitmap/roaring/pull/456/files>)
- *M* roaring64/bsi64.go
<https://github.com/RoaringBitmap/roaring/pull/456/files#diff-d1a31b49d0996408823b8c849e138363be8a4347d2e57cafd0ad289768845b46>
(4)
- *M* roaring64/bsi64_test.go
<https://github.com/RoaringBitmap/roaring/pull/456/files#diff-7fb44386e5551c3e6747d640bd9e1d99e75284a02b94ca0177849c566b86fc2f>
(6)
Patch Links:
- https://github.com/RoaringBitmap/roaring/pull/456.patch
- https://github.com/RoaringBitmap/roaring/pull/456.diff
—
Reply to this email directly, view it on GitHub
<#456>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZZAUQP5YU4OGSSPCDL4X3Z6GHENAVCNFSM6AAAAABQ5L3RG2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGYZDKOBRGI3TGNY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
in bsi64.go and bsi.go file, if foundSet is nil, is it all set to exisitence bitmap? |
|
i think these function may all hava nil pointer problem when parameter is nil
|
|
Yes. Also in CompareBigValue. If 'end' is not set it will panic also
El jue, 31 de oct de 2024, 3:37 a. m., ChicChip ***@***.***>
escribió:
… in bsi64.go and bsi.go file, if foundSet is nil, is it all set to
exisitence bitmap?
—
Reply to this email directly, view it on GitHub
<#456 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZZAUU72LVNI6DXY7W34L3Z6H24LAVCNFSM6AAAAABQ5L3RG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBZGQZDKMBSGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i fixed fix use nil parameter, the MinMaxBig func will throw panic's problem (#455)