Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: RoaringBitmap::from_lsb0_bytes #288

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Feature Request: RoaringBitmap::from_lsb0_bytes #288

wants to merge 10 commits into from
+321 −5

Commits on Oct 31, 2024

  1. Impl RoaringBitmap::from_bitmap_bytes

    @lemolatoon
    lemolatoon committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    32b4d60 View commit details
    Browse the repository at this point in the history

  2. Add benchmark for from_bitmap_bytes

    @lemolatoon
    lemolatoon committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    9834c01 View commit details
    Browse the repository at this point in the history

  3. Handle big endian system in from_bitmap_bytes

    @lemolatoon
    lemolatoon committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    4c4a2dd View commit details
    Browse the repository at this point in the history

  4. Add big endian test to CI

    @lemolatoon
    lemolatoon committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b15c11b View commit details
    Browse the repository at this point in the history

  5. Update description of bit order in from_bitmap_bytes

    @lemolatoon
    lemolatoon committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0758f8a View commit details
    Browse the repository at this point in the history

  6. Speed up from_bitmap_bytes, and use less unsafe 

    * Directly create an array/bitmap store based on the count of bits
* Use u64 words to count bits and enumerate bits
* Store in little endian, then just fixup any touched words
* Only use unsafe to reinterpret a whole bitmap container as bytes, everything
  else is safe
* Allow adding bytes up to the last possible offset
    @Dr-Emann @lemolatoon
    Dr-Emann authored and lemolatoon committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    e9a215c View commit details
    Browse the repository at this point in the history

  7. add special case for creating a full bitmap container 

    we can setting an initial value in that case
    @Dr-Emann @lemolatoon
    Dr-Emann authored and lemolatoon committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    09e9d6d View commit details
    Browse the repository at this point in the history

  8. Apply cargo fmt

    @lemolatoon
    lemolatoon committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f0dbb72 View commit details
    Browse the repository at this point in the history

  9. Rename from_bitmap_bytes to from_lsb0_bytes

    @lemolatoon
    lemolatoon committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    915e582 View commit details
    Browse the repository at this point in the history

  10. Fix CI error

    @lemolatoon
    lemolatoon committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    53ec34b View commit details
    Browse the repository at this point in the history