Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small issue, more params for RANDOMCHILDOF and new smartblock command FIRSTCHILDOFMENTION #124

Closed
wants to merge 3 commits into from

Conversation

baibhavbista
Copy link
Contributor

@baibhavbista baibhavbista commented Nov 2, 2024

@mdroidian @dvargas92495

Video explaining this PR: https://www.loom.com/share/8289de7d9d4c4439b6295f26a7c31c21

  • fix recursion bug for smartblocks which accept levelsIncluded param
  • add params levelsIncluded, format and optional filter values i.e. search in SB RANDOMCHILDOF
    • that SB should maybe be named RANDOMCHILDOFMENTION but IDK if we can change that
    • Output:: fadb3d8
  • add FIRSTCHILDOFMENTION smart block

Video: New SmartBlocks Features demo using "One article a day" workflow: https://www.loom.com/share/72b75508e86c45da93d645902736d49a
(which uses the changes from this PR)

Copy link
Collaborator

@dvargas92495 dvargas92495 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - @mdroidian could you pull down to clean up comments, run prettier, and publish?

@baibhavbista
Copy link
Contributor Author

@dvargas92495 thanks!
Do you have any thoughts regarding the possibility of renaming RANDOMCHILDOF to be something like RANDOMCHILDOFMENTION? Do you think it's a clearer name? Also do you have a way to deprecate older smartblocks (while still allowing them)? If yes, we could deprecate that, and mention in the documentation of RANDOMCHILDOFMENTION that it was previously RANDOMCHILDOF?

@dvargas92495
Copy link
Collaborator

Yea the rename makes sense to me. The way we would likely deprecate is to have the callback of the latter referenced in both places. We don't really have a deprecation pattern yet - I'll leave up to @mdroidian to design

@mdroidian
Copy link
Collaborator

Merged here: #125

@mdroidian mdroidian closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants