Print errors and make JSON output indented #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we make the pretty print an option that is passed in from the command line instead, and defaulting it to off? While I agree that pretty printing is nice, when you are returning very large result sets it does increase the amount of data to be sent by a LOT so being able to turn it on and off would be nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I'm not entirely used to the MBean world, the fact that there was no error printing at all was not so helpful :-)
In addition, the output was rather cryptic until I added some indentation. I've tested against Zabbix 2.2, and the indended/prettyprinted JSON is still accepted and used correctly.