Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

✨ Hyperoptable protections #150

Merged
merged 5 commits into from
Dec 18, 2021
Merged

✨ Hyperoptable protections #150

merged 5 commits into from
Dec 18, 2021

Conversation

raftersvk
Copy link
Contributor

since it is now available in freqtrade, I added the function with some parameters to be able to HO protections with MGM

@Rikj000 Rikj000 added Feature - New New feature or pull request Needs Testing This feature, improvement or bugfix still is in need of testing Planned Planned feature, improvement or bugfix (not being worked on yet) labels Oct 3, 2021
@Rikj000 Rikj000 linked an issue Oct 3, 2021 that may be closed by this pull request
🐞 Fix bugs introduced by updating Freqtrade #91
Closed
@Rikj000 Rikj000 changed the title Hyperoptable protections ✨ Hyperoptable protections Oct 3, 2021
@Rikj000 Rikj000 self-requested a review October 3, 2021 19:58
@Rikj000
Copy link
Owner

Rikj000 commented Oct 3, 2021

Good work @raftersvk 🦾 Already noticed something fly by about HyperOptable protections in the Freqtrade server 😄
However merging this PR will have to wait until after the next release of MGM.

The current version of Freqtrade that MoniGoMani uses doesn't have the ability yet to use HyperOptable protections.
I plan to hold off with updating Freqtrade to it's latest until all the currently planned issues for the next MoniGoMani release have been implemented.
Updating Freqtrade will likely bring new bugs to the table (see issue 91)

@Rikj000
Copy link
Owner

Rikj000 commented Oct 17, 2021 •
edited
Loading

Don't mind that Read the Docs check! It's been disabled for PRs now 😉

@Rikj000 Rikj000 added this to the v0.13.0 milestone Oct 28, 2021
@Rikj000 Rikj000 marked this pull request as draft December 16, 2021 17:18
@Rikj000 Rikj000 added In Progress This is being worked on and removed Planned Planned feature, improvement or bugfix (not being worked on yet) labels Dec 18, 2021
@Rikj000 Rikj000 self-assigned this Dec 18, 2021
@Rikj000 Rikj000 changed the base branch from development to support/freqtrade-2021.11 December 18, 2021 16:41
Rikj000
Rikj000 approved these changes Dec 18, 2021
View reviewed changes
Copy link
Owner

@Rikj000 Rikj000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging into support/freqtrade-2021.11
(This support branch will be merged into development once full support has been established & confirmed through testing on my local end)

@Rikj000 Rikj000 marked this pull request as ready for review December 18, 2021 16:46
@Rikj000 Rikj000 merged commit 199fa57 into Rikj000:support/freqtrade-2021.11 Dec 18, 2021
@Rikj000 Rikj000 mentioned this pull request Dec 23, 2021
Closed
@Rikj000 Rikj000 linked an issue Dec 23, 2021 that may be closed by this pull request
✨ Implement configurable hyperoptable protections #221
Closed
@raftersvk raftersvk deleted the hyperoptable-protections branch January 2, 2022 14:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Rikj000 Rikj000 Rikj000 approved these changes

Assignees

@Rikj000 Rikj000

@raftersvk raftersvk

Labels
Feature - New New feature or pull request In Progress This is being worked on Needs Testing This feature, improvement or bugfix still is in need of testing
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

✨ Implement configurable hyperoptable protections 🐞 Fix bugs introduced by updating Freqtrade
2 participants
@raftersvk @Rikj000