Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event queue fix #97

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Commits on Sep 30, 2021

  1. Fix event queue handling

    Send all queued events with "timestamp < buffer timestamp" instead of just the 1st one before sending the buffer.
    
    Only the 1st event of the event queue with "timestamp < buffer timestamp" was being send before the buffer.
    But there could be several events in the queue that should sent before the buffer.
    
    Fixes RidgeRun#96
    
    The segment event was not being handled properly when using x264enc + mpegtsmux together with interpipesrc/sink.
    Which was causing 2 segment to be delivered to the mpegtsmux:
    1st one generated by the interpipesrc (starting from zero) because no segment existed.
    2nd coming from the x264 encoder (correcting the 1000 hours offset added by the encoder).
    
    The 1st segment resulted in all subsequent DTS being seen as invalid (backwards) by the muxer.
    
    This happened because the event queue contained the following: stream-start, segment, tag, tag, tag.
    All with timestamp 0.
    But only the stream-start was sent, then the 1st buffer, then the segment.
    Which caused the DTS issues.
    mariannasb authored and Marianna Smidth Buschle committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    ac06ae2 View commit details
    Browse the repository at this point in the history