Enhancement #1774: Add option to bypass checking for .osxphotos_export.db in the export folder. #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing adjustment to find_first_file_in_branch.
…ist of first file found.
* Removed exclusivity of options --update and --ignore-exportdb * Search for files logic will also **not be done** in case options --exportdb or --no-exportdb are used. * Adjusted option definition. Maybe a bit lengthy 😞 ! * Renamed function find_files_in_branch into find_first_file_in_branch and revised logic to return on first occurrence found, when --ignore-exportdb is not active. * When --update is not used, added warnings when --ignore-exportdb is in use to make it compatible with interactive questions.
RhetTbull
requested changes
Jan 4, 2025
There was a problem hiding this comment.
Thanks for this. find_first_file_in_branch should now return either None or a single str with the file path instead of a list or empty list.
Also, please change other_db_files to other_db_file as we won't know if there's more than one and the subsequent warning that lists out the files to now say "file" vs "files". This will help the code be more clear down the road for maintenance.
Otherwise this looks good!
- find_first_file_in_branch should now return either None or a single str with the file path instead of a list or empty list. - Change other_db_files to other_db_file and the subsequent warning that lists out the files to now say "file" vs "files".
…ate_child_folder"
…thub.com/RhetTbull/osxphotos/actions/runs/12612637331/job/35149593923#step:9:261) * Unable to re-run Tests up-stream :( * Adjusting some long lines and forcing commit!
RhetTbull
approved these changes
Jan 5, 2025
|
Thanks for implementing this! I have a few more things I'm working on before the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement #1774: Add option to bypass checking for .osxphotos_export.db in the export folder.