fix: brigadier error when only optional flags and switches#140
Merged
Revxrsal merged 1 commit intoRevxrsal:v4from Sep 12, 2025
Merged
fix: brigadier error when only optional flags and switches#140Revxrsal merged 1 commit intoRevxrsal:v4from
Revxrsal merged 1 commit intoRevxrsal:v4from
Conversation
Until now, calling commands having only optional flags and/or switches without specifying any of those flag or switch resulted in an "incomplete command" Brigadier error.
Contributor
Author
|
I tested in a plugin of mine (a simple command with 1 switch) and it's working properly. |
Owner
|
LGTM. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, calling commands having only optional flags and/or switches without specifying any of those flag or switch resulted in an "incomplete command" Brigadier error.
Fixes #137.
This is really blocking for commands that rely on switches. The only workaround is to create a separate command. I hope this fix handles all cases.