Uploaded all the images of the previous website and the base template of the last site's homepage #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falsepopsky
requested changes
Jul 10, 2024
frontend/package-lock.json
Outdated
There was a problem hiding this comment.
use pnpm for install
corepack enable & pnpm install
| @@ -16,7 +19,21 @@ export default function RootLayout({ | |||
| }>) { | |||
| return ( | |||
| <html lang="en"> | |||
| <body className={inter.className}>{children}</body> | |||
| <head> | |||
| <meta charSet="utf-8"/> | |||
There was a problem hiding this comment.
do you have experience with Next.js?
yo should use:
https://nextjs.org/docs/app/building-your-application/optimizing/metadata
| @@ -0,0 +1,345 @@ | |||
| * { | |||
There was a problem hiding this comment.
tailwind already handles most of this., so some styles classes should be removed
Comment on lines
+34
to
+35
| <body className={inter.className}> | ||
| <Navbar></Navbar> |
There was a problem hiding this comment.
it should be <Navbar />
frontend/src/app/navigationbar.tsx
Outdated
| <nav> | ||
| <ul className="flex justify-between text-2xl"> | ||
| <li className="mr-6"> | ||
| <a className="text-blue-500 hover:text-blue-800" href="/">Home</a> |
There was a problem hiding this comment.
| </a> | ||
| return ( <div> | ||
| <header> | ||
| <img src="img/logo.png" width="500" height="500" alt="Retro Olympics"/> |
There was a problem hiding this comment.
Comment on lines
+10
to
+12
| <h3>The 2023-2024 season is coming!</h3> | ||
| <h2>Gather your team and prepare for the...</h2> | ||
| <h1>RETRO OLYMPICS!</h1> |
There was a problem hiding this comment.
if this is a text you should use the p tag instead, don't use headers for non titles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe it is worth it to restructure the folders in this, but right now, this seemed like an okay start.