Frei/device memory support rebased #517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without unified memory (e.g. dGPUs)
used in tutorials.
interface was missing
dopitz
force-pushed
the
frei/device_memory_support_rebased
branch
from
04715ce to
82d5580
Compare
|
squashed WIP commits for latest change |
dopitz
force-pushed
the
frei/device_memory_support_rebased
branch
from
82d5580 to
cee738e
Compare
|
removed nonessential nightly tests after rthw internal builder removal |
|
The kernels/level_zero/ze_rtas.h file is no longer required. The ze_wrapper/zeDeviceGetRTASProperties function can go, and the ZE_RTAS_FORMAT_EXP_VERSION_1/2/MAX are then no longer required. After that removed too it looks fine. |
svenwoop
requested changes
Jan 20, 2025
dopitz
force-pushed
the
frei/device_memory_support_rebased
branch
from
cee738e to
8d230cb
Compare
dopitz
force-pushed
the
frei/device_memory_support_rebased
branch
from
8d230cb to
6702c2b
Compare
addressed those changes with the latest update |
This reverts commit d3c165b. newest public driver under linux does not fix this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is green, I THINK, the documentation doesn't need additional updates after removing the
EMBREE_SYCL_L0_RTAS_BUILDERcmake flag