Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the JS renderer respect the offset from the database #13

Merged
merged 1 commit into from
Aug 24, 2020
Merged

make the JS renderer respect the offset from the database #13

merged 1 commit into from
Aug 24, 2020

Conversation

glynnbird
Copy link
Member

Ensure that the JS renderer respects the offset coming from the DB.

see #10 & https://github.com/orgs/Choirless/projects/3#card-43852148

hammertoe
hammertoe approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@hammertoe hammertoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@glynnbird
Copy link
Member Author

Will merge after discussion 👍

@hammertoe hammertoe merged commit e9d996f into master Aug 24, 2020
@krook krook deleted the respectoffset branch March 11, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hammertoe hammertoe hammertoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glynnbird @hammertoe