Added healthcheck and conditions per container #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chayim
reviewed
Jan 30, 2024
| @@ -6,7 +6,6 @@ fi | |||
|
|
|||
| ## Build infrastructure ## | |||
| docker-compose up -d | |||
| sleep 10 | |||
There was a problem hiding this comment.
I think you still need the sleep, since it takes time to settle. Healthcheck + sleep?
There was a problem hiding this comment.
I don't think so, each container runs only if previous is "healthy", in this case it means that REST API is accessible. When we creating cluster we only care about master-node to be "healthy" cause we're making a REST API call to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.