GH actions deprecation fixes: migrate checkout github action from v2 to v4 and [email protected]/1.0 fixes. #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipecosta90
force-pushed
the
migrate.v2.v4.checkout
branch
from
05ab967 to
8b057f0
Compare
…[email protected] runs due do deprecation notices.
filipecosta90
force-pushed
the
migrate.v2.v4.checkout
branch
from
8b057f0 to
0bc08bc
Compare
filipecosta90
changed the title
filipecosta90
changed the title
yossigo
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkout change
Following the error in: https://github.com/RedisLabs/memtier_benchmark/actions/runs/11958405087/job/33340558967
we can see in https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ node12 is deprectated and node16 as well.
We should bump checkout actions from v2 to v4 to solve this.
macos changes
According to https://github.com/actions/runner-images/blob/macos-14-arm64/20241119.509/images/macos/macos-14-arm64-Readme.md
so we use macos-12 which does not have the deprecation notice and won't fail.