Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring we produce a valid JSON in case of empty string and -nan #273

Merged
merged 5 commits into from
Nov 18, 2024

Ensuring that the per second metrics are numeric non negative

bfe511c
Select commit
Loading
Failed to load commit list.
Merged

Ensuring we produce a valid JSON in case of empty string and -nan #273

Ensuring that the per second metrics are numeric non negative
bfe511c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 7, 2024 in 0s

65.26% (+0.72%) compared to 104ed9f

View this Pull Request on Codecov

65.26% (+0.72%) compared to 104ed9f

Details

Codecov Report

Attention: Patch coverage is 70.32967% with 27 lines in your changes missing coverage. Please review.

Project coverage is 65.26%. Comparing base (104ed9f) to head (bfe511c).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
run_stats.cpp 54.38% 26 Missing ⚠️
JSON_handler.cpp 94.11% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   64.53%   65.26%   +0.72%     
==========================================
  Files          21       21              
  Lines        4368     4445      +77     
==========================================
+ Hits         2819     2901      +82     
+ Misses       1549     1544       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov