Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitattributes file for better behavior on Windows-based systems #266

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

DrEsteban
Copy link
Contributor

@DrEsteban DrEsteban commented Sep 10, 2024

Adding this file will ensure text files are checked out on all dev systems as LF, which is required for this project to build correctly.

As mentioned in #163, if you check out this project on a Windows system and try to docker build, you'll get:

7.187 configure: creating ./config.status
.in'7 config.status: error: cannot find input file: `

I determined this is because text-based files that are expected to be LF at build time are being automatically checked out as CRLF on Windows machines. When those CRLF files are copied over to a Linux-based Docker context at build time, they cause the build to blow up. After renormalizing all text files as LF, the build succeeds as expected.

This change will ensure all contributors, no matter the dev OS, will be able to work with this repository as intended immediately upon checkout.

...to ensure text files are checked out on all dev systems as LF, which is **required** for this project to build correctly.
@DrEsteban
Copy link
Contributor Author

@filipecosta90 this should be a fairly low-risk change. The only net change that will be seen is on Windows systems upon checkout of the repo - text files will default to LF line endings rather than CRLF, which is required to build successfully.

@filipecosta90 filipecosta90 self-requested a review September 25, 2024 16:13
@filipecosta90
Copy link
Collaborator

@filipecosta90 this should be a fairly low-risk change. The only net change that will be seen is on Windows systems upon checkout of the repo - text files will default to LF line endings rather than CRLF, which is required to build successfully.

merging @DrEsteban :) Thank you!

@filipecosta90 filipecosta90 merged commit 91d142e into RedisLabs:master Sep 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants