Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TLS --tls-protocols parsing. #241

Merged
merged 7 commits into from
Dec 2, 2023
Merged

Fixed TLS --tls-protocols parsing. #241

merged 7 commits into from
Dec 2, 2023

Conversation

filipecosta90
Copy link
Collaborator

No description provided.

@filipecosta90 filipecosta90 changed the title Fixed TLS args test. More verbose error output on --tls-protocols parsing Fixed TLS --tls-protocols parsing. Nov 18, 2023
YaacovHazan
YaacovHazan previously approved these changes Nov 18, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (bec3471) 56.41% compared to head (c5c51e5) 56.90%.
Report is 2 commits behind head on master.

Files Patch % Lines
memtier_benchmark.cpp 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   56.41%   56.90%   +0.49%     
==========================================
  Files          21       21              
  Lines        4359     4388      +29     
==========================================
+ Hits         2459     2497      +38     
+ Misses       1900     1891       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filipecosta90 filipecosta90 merged commit a5e6f19 into master Dec 2, 2023
8 checks passed
@filipecosta90 filipecosta90 deleted the fix.tls.args branch December 2, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants