-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHINENG-7833] - Send notification newly-stale hosts #2123
Open
jpramos123
wants to merge
9
commits into
RedHatInsights:master
Choose a base branch
from
jpramos123:add-notif-stale-host
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpramos123
force-pushed
the
add-notif-stale-host
branch
from
December 12, 2024 21:35
ee80365
to
952eaa5
Compare
jpramos123
force-pushed
the
add-notif-stale-host
branch
5 times, most recently
from
December 17, 2024 13:28
746edf5
to
8061985
Compare
/retest |
jpramos123
force-pushed
the
add-notif-stale-host
branch
5 times, most recently
from
December 17, 2024 19:27
84ed896
to
6820653
Compare
jpramos123
force-pushed
the
add-notif-stale-host
branch
from
December 17, 2024 20:37
6820653
to
c9a1324
Compare
FabriciaDinizRH
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs more tests, but I'll not block it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is being created to address RHINENG-7833.
It adds the functionality of sending notitications for hosts that went stale in the last X seconds. To define this X seconds, an environment variable called
STALE_VALIDATION_WINDOW_SECONDS
was created, its default values is set to 1 hour.It also refacts the host reaper, as this new feature is also a job that runs every certain amount of time. The common code used by both jobs were added to the
jobs/common.py
file.PR Checklist
Secure Coding Practices Documentation Reference
You can find documentation on this checklist here.
Secure Coding Checklist