Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(V2): RHINENG-11269 use the V2 models for SSG import #2237

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skateman
Copy link
Member

@skateman skateman commented Oct 9, 2024

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@skateman skateman force-pushed the datastream-import-v2 branch 2 times, most recently from 1b6bea7 to 0c102f6 Compare October 9, 2024 06:10
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 30.33708% with 62 lines in your changes missing coverage. Please review.

Project coverage is 95.67%. Comparing base (9556f4b) to head (828e5d0).

Files with missing lines Patch % Lines
app/services/concerns/xccdf/security_guides.rb 47.82% 12 Missing ⚠️
app/services/concerns/xccdf/rule_groups.rb 12.50% 7 Missing ⚠️
...rvices/concerns/xccdf/profile_os_minor_versions.rb 0.00% 6 Missing ⚠️
app/models/v2/rule.rb 33.33% 4 Missing ⚠️
app/models/v2/value_definition.rb 33.33% 4 Missing ⚠️
app/services/concerns/xccdf/profile_rules.rb 0.00% 4 Missing ⚠️
app/services/concerns/xccdf/profiles.rb 0.00% 4 Missing ⚠️
app/services/concerns/xccdf/rules.rb 0.00% 4 Missing ⚠️
app/services/concerns/xccdf/value_definitions.rb 0.00% 4 Missing ⚠️
app/models/v2/profile.rb 25.00% 3 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2237      +/-   ##
==========================================
- Coverage   98.78%   95.67%   -3.12%     
==========================================
  Files         237      235       -2     
  Lines        5197     5178      -19     
==========================================
- Hits         5134     4954     -180     
- Misses         63      224     +161     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skateman
Copy link
Member Author

/retest

@skateman skateman force-pushed the datastream-import-v2 branch from 0c102f6 to 5de48b7 Compare November 1, 2024 09:16
@skateman skateman force-pushed the datastream-import-v2 branch from 5de48b7 to 828e5d0 Compare November 1, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant