Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace numerical values where a spacing token can be used #2156

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −9
Draft

docs: replace numerical values where a spacing token can be used #2156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions elements/rh-avatar/docs/20-guidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,11 @@ centered.

### Stacking

There is `48px` of space when avatar groups are stacked vertically.
There should be a spacing of `--rh-space-3xl` between avatar groups that are stacked vertically.

<uxdot-example width-adjustment="385px">
<img src="../avatar-usage-stacking.png"
alt="Image of three avatar groups stacked vertically with 48 pixel of space in between"
alt="Image of three avatar groups stacked vertically"
width="385"
height="288">
</uxdot-example>
Expand Down
6 changes: 3 additions & 3 deletions elements/rh-button/docs/20-guidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,9 @@ Group buttons logically into sets based on hierarchy and usage.

### Space in groups

The standard spacing between each button is `16px`, even for Danger
buttons. If buttons are stacked, the spacing between each button should be
`8px`.
The standard spacing between each button is `--rh-space-lg`, even for Danger
buttons. If buttons are stacked vertically, the spacing between each button should be
`--rh-space-md`.

<uxdot-example width-adjustment="508px">
<img src="../button-layout-spacing.png"
Expand Down
5 changes: 2 additions & 3 deletions elements/rh-cta/docs/20-guidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,7 @@ Brick variants are flexible and can stretch to fit different column widths.

### Space in groups

Horizontal and vertical spacing between Primary and Secondary variants is
`24px`.
Horizontal and vertical spacing between Primary and Secondary variants should use the `--rh-space-xl` token.

<rh-alert state="info">
<h4 slot="header">Helpful tip</h4>
Expand All @@ -309,7 +308,7 @@ Horizontal and vertical spacing between Primary and Secondary variants is
height="256">
</uxdot-example>

Horizontal and vertical spacing between the Default variant is `24px`.
Horizontal and vertical spacing between Default variants should use the `--rh-space-xl` token.

<uxdot-example width-adjustment="705px">
<img src="../cta-layout-space-in-groups-2.png"
Expand Down
2 changes: 1 addition & 1 deletion elements/rh-tag/docs/10-style.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ Only tags with linked text have interaction states.

### Hover

The tag border changes to `--rh-border-width-md` or `2px` on hover.
The tag border width increases to `--rh-border-width-md` on hover.

<uxdot-example width-adjustment="555px">
<img src="../tag-style-interaction-states-hover.svg"
Expand Down