Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blockquote): fix center alignment, enforce blockquote font size and update Style docs #2112

Merged
merged 16 commits into from
Jan 10, 2025
Merged

fix(blockquote): fix center alignment, enforce blockquote font size and update Style docs #2112

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b587f1d
fix(blockquote): override potential `max-width` for quote content
adamjohnson Jan 8, 2025
1fa4845
chore(blockquote): add changeset
adamjohnson Jan 8, 2025
f5f0a57
fix(blockquote): use logical properties
adamjohnson Jan 8, 2025
525c063
fix(blockquote): update quote and author spacing
adamjohnson Jan 9, 2025
4b22f70
docs(blockquote): update maximum width size
adamjohnson Jan 9, 2025
023d7e9
feat(blockquote): limit width to 752px per docs
adamjohnson Jan 9, 2025
b6b4eb6
docs(blockquote): remove "Image of" at start of alt text
adamjohnson Jan 9, 2025
7f75d18
docs(blockquote): remove a11y note about `aria-label`
adamjohnson Jan 9, 2025
40c4c87
fix(blockquote): use standard media query size
adamjohnson Jan 9, 2025
0fdb121
docs(blockquote): re-add content to sizes table
adamjohnson Jan 9, 2025
33c227d
docs(blockquote): fix and update themable tokens link on Style page
adamjohnson Jan 9, 2025
aa82561
fix(blockquote): increase/correct slotted content `font-size`
adamjohnson Jan 9, 2025
6397b28
fix(blockquote): use tag selector in CSS for quote
adamjohnson Jan 9, 2025
698334b
fix(blockquote): target `p` tag for blockquote specifically
adamjohnson Jan 9, 2025
4d6caab
fix(blockquote): use standard media query size
adamjohnson Jan 9, 2025
a0bee2e
chore(blockquote): upgrade changeset to minor
adamjohnson Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thick-flowers-beam.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rhds/elements": patch
---

`<rh-blockquote>`: make quote content centered when `align="center"`
6 changes: 5 additions & 1 deletion elements/rh-blockquote/rh-blockquote.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
:host {
color: var(--rh-color-text-primary);
margin: 0 auto;
text-align: left;
text-align: start;
font-size: var(--rh-font-size-body-text-lg, 1.125rem);
font-family: var(--rh-font-family-heading, RedHatDisplay, 'Red Hat Display', 'Noto Sans Arabic', 'Noto Sans Hebrew', 'Noto Sans JP', 'Noto Sans KR', 'Noto Sans Malayalam', 'Noto Sans SC', 'Noto Sans TC', 'Noto Sans Thai', Helvetica, Arial, sans-serif);
line-height: var(--rh-line-height-body-text, 1.5);
Expand Down Expand Up @@ -45,6 +45,10 @@ rh-icon {
text-align: center;
}

:host([align='center']) #quote ::slotted(*) {
max-inline-size: none !important;
}

:host([size='large']) {
font-size: var(--rh-font-size-body-text-2xl, 1.5rem);
line-height: var(--rh-line-height-heading, 1.3);
Expand Down
Loading