feat(dialog): use native HTML dialog element

[adamjohnson]

What I did

1. This is a continuation of feat(dialog): use native HTML dialog element #1865. Opening this as a separate PR because of merge conflicts in 1865.
2. Please review the PR body and comments thoroughly from 1865 for changes
   • Highlights:
     • Now uses the native HTML <dialog> element.
     • Added the accessible-label property
     • Improved modal styles
     • Focus trapping
     • Updated a11y docs
     • rh-surface wrapping only <dialog> element

Testing Instructions

1. Visit the DP Demo.
2. View the other demos:
   • Color Context
   • Events
   • Lots of Content
   • No headings
   • No header content
   • Video
3. Add various elements to modal header, body, footer
4. Test variants (variant="small" etc and position="top")
5. Check a11y
6. Check for appropriate spacing

Notes to Reviewers

Docs updates:

• Some docs on the Guidelines page are incorrect as they have the modal body scrolling independently from the header and footer. This is not possible short of a variant.
• Guidelines for the video player close button location differ from actual implementation (update image)
• Guidelines for Overflow content differ from implementation (update text, image)
• Border radius of dialog in images

Closes #1242 and #1238.

[changeset-bot]

🦋 Changeset detected

Latest commit: 9ebd037

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@rhds/elements	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for red-hat-design-system ready!

Name	Link
🔨 Latest commit	9ebd037
🔍 Latest deploy log	https://app.netlify.com/sites/red-hat-design-system/deploys/67a5546169f1d200087ed86c
😎 Deploy Preview	https://deploy-preview-2078--red-hat-design-system.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Size Change: +185 B (+0.09%)

Total Size: 207 kB

Filename	Size	Change
./elements/rh-dialog/rh-dialog.js	4.96 kB	+185 B (+3.87%)

ℹ️ View Unchanged

Filename	Size
./elements.js	473 B
./elements/rh-accordion/context.js	162 B
./elements/rh-accordion/rh-accordion-header.js	2.69 kB
./elements/rh-accordion/rh-accordion-panel.js	1.35 kB
./elements/rh-accordion/rh-accordion.js	3.21 kB
./elements/rh-alert/rh-alert.js	4.26 kB
./elements/rh-audio-player/rh-audio-player-about.js	1.8 kB
./elements/rh-audio-player/rh-audio-player-rate-stepper.js	1.85 kB
./elements/rh-audio-player/rh-audio-player-scrolling-text-overflow.js	1.53 kB
./elements/rh-audio-player/rh-audio-player-subscribe.js	1.38 kB
./elements/rh-audio-player/rh-audio-player.js	13.1 kB
./elements/rh-audio-player/rh-cue.js	1.95 kB
./elements/rh-audio-player/rh-transcript.js	2.7 kB
./elements/rh-avatar/random-pattern-controller.js	2.72 kB
./elements/rh-avatar/rh-avatar.js	2.85 kB
./elements/rh-back-to-top/rh-back-to-top.js	2.1 kB
./elements/rh-badge/rh-badge.js	1.55 kB
./elements/rh-blockquote/rh-blockquote.js	1.43 kB
./elements/rh-breadcrumb/rh-breadcrumb.js	1.5 kB
./elements/rh-button/rh-button.js	4.24 kB
./elements/rh-card/rh-card.js	3.58 kB
./elements/rh-code-block/prism.css.js	667 B
./elements/rh-code-block/prism.js	572 B
./elements/rh-code-block/rh-code-block.js	7.34 kB
./elements/rh-cta/rh-cta.js	4.04 kB
./elements/rh-dialog/yt-api.js	617 B
./elements/rh-footer/rh-footer-block.js	714 B
./elements/rh-footer/rh-footer-copyright.js	362 B
./elements/rh-footer/rh-footer-links.js	1.17 kB
./elements/rh-footer/rh-footer-social-link.js	964 B
./elements/rh-footer/rh-footer-universal.js	3.99 kB
./elements/rh-footer/rh-footer.js	4.96 kB
./elements/rh-health-index/rh-health-index.js	2.35 kB
./elements/rh-icon/rh-icon.js	2.47 kB
./elements/rh-icon/ssr.js	181 B
./elements/rh-menu/rh-menu.js	1.29 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js	2.47 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js	1.3 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu.js	1.75 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js	571 B
./elements/rh-navigation-secondary/rh-navigation-secondary.js	5.26 kB
./elements/rh-navigation-secondary/test/fixtures.js	769 B
./elements/rh-pagination/rh-pagination.js	5.41 kB
./elements/rh-site-status/rh-site-status.js	2.5 kB
./elements/rh-skip-link/rh-skip-link.js	1.19 kB
./elements/rh-spinner/rh-spinner.js	1.38 kB
./elements/rh-stat/rh-stat.js	2.13 kB
./elements/rh-subnav/rh-subnav.js	2.73 kB
./elements/rh-surface/rh-surface.js	1.14 kB
./elements/rh-surface/test/elements.js	423 B
./elements/rh-switch/rh-switch.js	2.93 kB
./elements/rh-table/rh-sort-button.js	1.49 kB
./elements/rh-table/rh-table.js	3.48 kB
./elements/rh-tabs/context.js	160 B
./elements/rh-tabs/rh-tab-panel.js	1.04 kB
./elements/rh-tabs/rh-tab.js	3.02 kB
./elements/rh-tabs/rh-tabs.js	3.77 kB
./elements/rh-tag/rh-tag.js	2.79 kB
./elements/rh-tile/rh-tile-group.js	1.81 kB
./elements/rh-tile/rh-tile.js	5.09 kB
./elements/rh-timestamp/rh-timestamp.js	983 B
./elements/rh-tooltip/rh-tooltip.js	2.73 kB
./elements/rh-video-embed/rh-video-embed.js	4.59 kB
./lib/context/color/consumer.js	1.41 kB
./lib/context/color/controller.js	947 B
./lib/context/color/provider.js	2.18 kB
./lib/context/event.js	593 B
./lib/context/headings/consumer.js	722 B
./lib/context/headings/controller.js	1.12 kB
./lib/context/headings/provider.js	1.24 kB
./lib/DirController.js	565 B
./lib/elements/rh-context-demo/rh-context-demo.js	1.28 kB
./lib/elements/rh-context-picker/rh-context-picker.js	2.24 kB
./lib/environment.js	194 B
./lib/functions.js	175 B
./lib/I18nController.js	1.38 kB
./lib/ScreenSizeController.js	849 B
./lib/ssr-controller.js	251 B
./react/rh-accordion/rh-accordion-header.js	199 B
./react/rh-accordion/rh-accordion-panel.js	185 B
./react/rh-accordion/rh-accordion.js	215 B
./react/rh-alert/rh-alert.js	184 B
./react/rh-audio-player/rh-audio-player-about.js	191 B
./react/rh-audio-player/rh-audio-player-rate-stepper.js	213 B
./react/rh-audio-player/rh-audio-player-scrolling-text-overflow.js	214 B
./react/rh-audio-player/rh-audio-player-subscribe.js	196 B
./react/rh-audio-player/rh-audio-player.js	183 B
./react/rh-audio-player/rh-cue.js	195 B
./react/rh-audio-player/rh-transcript.js	207 B
./react/rh-avatar/rh-avatar.js	173 B
./react/rh-back-to-top/rh-back-to-top.js	183 B
./react/rh-badge/rh-badge.js	174 B
./react/rh-blockquote/rh-blockquote.js	179 B
./react/rh-breadcrumb/rh-breadcrumb.js	179 B
./react/rh-button/rh-button.js	174 B
./react/rh-card/rh-card.js	172 B
./react/rh-code-block/rh-code-block.js	181 B
./react/rh-cta/rh-cta.js	170 B
./react/rh-dialog/rh-dialog.js	203 B
./react/rh-footer/rh-footer-block.js	184 B
./react/rh-footer/rh-footer-copyright.js	187 B
./react/rh-footer/rh-footer-links.js	185 B
./react/rh-footer/rh-footer-social-link.js	193 B
./react/rh-footer/rh-footer-universal.js	188 B
./react/rh-footer/rh-footer.js	174 B
./react/rh-health-index/rh-health-index.js	184 B
./react/rh-icon/rh-icon.js	202 B
./react/rh-menu/rh-menu.js	173 B
./react/rh-navigation-secondary/rh-navigation-secondary-dropdown.js	217 B
./react/rh-navigation-secondary/rh-navigation-secondary-menu-section.js	205 B
./react/rh-navigation-secondary/rh-navigation-secondary-menu.js	199 B
./react/rh-navigation-secondary/rh-navigation-secondary-overlay.js	201 B
./react/rh-navigation-secondary/rh-navigation-secondary.js	213 B
./react/rh-pagination/rh-pagination.js	178 B
./react/rh-site-status/rh-site-status.js	181 B
./react/rh-skip-link/rh-skip-link.js	181 B
./react/rh-spinner/rh-spinner.js	175 B
./react/rh-stat/rh-stat.js	171 B
./react/rh-subnav/rh-subnav.js	175 B
./react/rh-surface/rh-surface.js	175 B
./react/rh-switch/rh-switch.js	185 B
./react/rh-table/rh-sort-button.js	213 B
./react/rh-table/rh-table.js	174 B
./react/rh-tabs/rh-tab-panel.js	181 B
./react/rh-tabs/rh-tab.js	187 B
./react/rh-tabs/rh-tabs.js	174 B
./react/rh-tag/rh-tag.js	182 B
./react/rh-tile/rh-tile-group.js	183 B
./react/rh-tile/rh-tile.js	194 B
./react/rh-timestamp/rh-timestamp.js	176 B
./react/rh-tooltip/rh-tooltip.js	175 B
./react/rh-video-embed/rh-video-embed.js	227 B
./uxdot/uxdot-best-practice.js	742 B
./uxdot/uxdot-copy-button.js	1.2 kB
./uxdot/uxdot-copy-permalink.js	1.1 kB
./uxdot/uxdot-example.js	1.17 kB
./uxdot/uxdot-feedback.js	727 B
./uxdot/uxdot-header.js	1.07 kB
./uxdot/uxdot-hero.js	679 B
./uxdot/uxdot-installation-tabs.js	675 B
./uxdot/uxdot-masthead.js	809 B
./uxdot/uxdot-pattern-ssr-controller-client.js	604 B
./uxdot/uxdot-pattern-ssr-controller-server.js	1.68 kB
./uxdot/uxdot-pattern-ssr-controller.js	213 B
./uxdot/uxdot-pattern.js	2.12 kB
./uxdot/uxdot-repo-status-checklist.js	1.16 kB
./uxdot/uxdot-repo-status-list.js	1.07 kB
./uxdot/uxdot-repo-status-table.js	782 B
./uxdot/uxdot-repo.js	1.17 kB
./uxdot/uxdot-search.js	2.39 kB
./uxdot/uxdot-sidenav.js	2.67 kB
./uxdot/uxdot-spacer-tokens-table.js	2.45 kB
./uxdot/uxdot-toc.js	1.13 kB

_{compressed-size-action}

[marionnegp]

• The close button's target looks pretty large. Can we use --rh-length-xl for the width and height of the touch target?
  

• Can the slots use this spacing?

• Is there a way to keep the close button fixed if the content has to scroll?
  

• This comment might need to go back to design for a future feature update, but the close button isn't visible in the video dialog demo. (I can make an issue if design needs to tackle dark theme to fix this.)
  

[bennypowers]

Last few changes then we'll be ready to rock

[marionnegp]

I'll be making dialog docs updates in this branch/PR this week! Please don't merge before they're done.

[marionnegp]

@coreyvickery, I updated the dialog docs to accommodate some of the changes made in this PR. Could you take a look at the mockup and add any feedback?

[coreyvickery]

@marionnegp Mock-up looks good.

[marionnegp]

@coreyvickery @adamjohnson, feel free to take a look at the updated docs in the DP.

[coreyvickery]

@marionnegp Let me know if you still need my eyes on this.

[marionnegp]

@coreyvickery, I think we're good. Thank you!