Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use SHALLOW_DUPLICATE_ATTRIB() since that's API since R3.3.0 #6264

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

MichaelChirico
Copy link
Member

Follow-up to #6183, part of #6257. See also this comment thread: cd89ceb#r144215033

Copy link

github-actions bot commented Jul 15, 2024

Comparison Plot

Generated via commit d25666c

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 12 minutes and 59 seconds

Time taken to run atime::atime_pkg on the tests: 4 minutes and 1 seconds

@MichaelChirico MichaelChirico added this to the 1.16.0 milestone Jul 15, 2024
src/assign.c Outdated Show resolved Hide resolved
@MichaelChirico MichaelChirico changed the title More conservative PROTECT() around switch to API usage in asS4 Change to use SHALLOW_DUPLICATE_ATTRIB() since that's API since R3.3.0 Jul 16, 2024
@MichaelChirico
Copy link
Member Author

ping @ben-schwen :)

@ben-schwen
Copy link
Member

LGTM

@ben-schwen ben-schwen merged commit f952062 into master Jul 21, 2024
5 checks passed
@ben-schwen ben-schwen deleted the rchk-s4-protect branch July 21, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants