feat(kafka): add setup for helm charts #225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as i can understand rasa-x always need one of kafka or rabbitmq enabled, so install is separated and enable it's like if rabbit is enable so kafka is not, and if rabbit is not enabled kafka is, or i'm wrong? @tczekajlo |
|
@mesmerx You are correct that one of either RabbitMQ or Kafka is required. See here #207 (comment) for a conclusion of the discussion, whether Kafka should get its own section or not. |
|
However, since your PR would make it possible to launch kafka as part of the chart, this is slightly different. @tczekajlo Do we want to reconsider adding kafka to the charts natively? |
|
Confirmed that we're not going to be adding additional external components to the chart. #207 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.