Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story fragments -> rules #620

Merged
merged 4 commits into from
Mar 11, 2021
Merged

Story fragments -> rules #620

merged 4 commits into from
Mar 11, 2021

Conversation

samsucik
Copy link
Contributor

These small changes have been lingering in my code editor and I just wanted to push them before making some other (unrelated) changes to the training data.

I've turned 2 story fragments into rules but there are many, many more stories that should be changed like this.

@samsucik samsucik added the demo label Mar 10, 2021
@samsucik samsucik requested a review from indam23 March 10, 2021 16:14
Copy link
Contributor

@indam23 indam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, look like sensible changes

@samsucik
Copy link
Contributor Author

@melindaloubser1 fyi I've removed the faq -> utter_faq rule I had introduced. It was creating contradictions because sometimes we mis-use intent:faq for utterances like "rasa x" (the same way we mis-use the how_to_get_started and enter_data intents for this) and then the next action isn't utter_faq. And I couldn't be bothered to go down this deep rabbit hole and fix all of that.

@indam23
Copy link
Contributor

indam23 commented Mar 11, 2021

haha that is fair. Let's merge this, and if you think it's worth it could you create an issue for the outstanding rabbit hole?

@indam23 indam23 merged commit 5bc49b6 into main Mar 11, 2021
@samsucik
Copy link
Contributor Author

Yep, the issue is now here.

@indam23 indam23 deleted the story-fragments-into-rules branch May 17, 2021 09:14
hamzaziizzz pushed a commit to hamzaziizzz/rasa-demo that referenced this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants