Add integer scaling feature #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rampastring
requested changes
Sep 18, 2024
There was a problem hiding this comment.
There are more callsites for RecalculateScaling. This PR only adds the integerScale parameter to one of them.
I think it'd be better to add public bool IntegerScalingOnly { get; set; } as a property instead of as a parameter for SetRenderResolution, and use the value of that property in RecalculateScaling.
Rampastring
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: CnCNet/xna-cncnet-client#557
This PR adds an integer scaling mode. If set, only scales the rendered screen by integer scaling factors. Unfilled space is filled with black.