Add test for #1486 #746
Open
Add test for #1486 #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizmat
reviewed
Jul 6, 2021
S09-hashes/objecthash.t
Outdated
| @@ -140,6 +140,11 @@ plan 55; | |||
| eval-lives-ok 'my %*a{Int}', "Accept dynamic object hash" | |||
| } | |||
|
|
|||
| # https://github.com/rakudo/rakudo/issues/1486 | |||
| { | |||
| ok {:foo, (if 1 { :bar })}, 'a conditional inside circumfix {} works'; | |||
There was a problem hiding this comment.
Are we sure the static optimizer doesn't optimize the if 1 away?
There was a problem hiding this comment.
I hope the new version is complex enough?
vrurg
requested changes
Aug 12, 2021
| @@ -140,6 +140,11 @@ plan 55; | |||
| eval-lives-ok 'my %*a{Int}', "Accept dynamic object hash" | |||
| } | |||
|
|
|||
| # https://github.com/rakudo/rakudo/issues/1486 | |||
| { | |||
| ok {:foo, (if 0.5.rand < 1 { :bar })}, 'a conditional inside circumfix {} works'; | |||
There was a problem hiding this comment.
I'd like to ask about a comment explaining the approach about if. It's going to be really confusing what purpose of it without the background of this PR.
BTW, a sufficiently sophisticated static optimizer would optimize away this if too. But, unfortunately, we're not going get one of the kind any time soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes rakudo/rakudo#1486
I really don't know where to put this, in
literalsthere is nothing for hash literals andhashorhasheshave nothing related also, instead testing just methods.