Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of descriptor section #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brandjon
Copy link

I rewrote the descriptor example and prose.

The previous Meter/Foot example, as written, stored the state in the descriptor object rather than the instances of the Distance class. This means that all Distances would have the same state, which is clearly undesirable. I also got rid of the meter descriptor, turning it into a regular attribute and making feet a view over meters. I think this more clearly illustrates how descriptors can be used.

I changed the prose to be more precise, trying not to increase verbiage.

I regenerated the documentation as mentioned in the project readme, but it also regenerated other changes prior to mine, and formatted the output differently from what was already there. So I put the document regeneration in a completely separate commit in case you want to ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant