-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for a single feed #394
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2019 2057 +38
=========================================
+ Hits 2019 2057 +38 ☔ View full report in Codecov by Sentry. |
c28cf25
to
a81053d
Compare
f8825c1
to
a84733d
Compare
a84733d
to
1a49c3c
Compare
Add testing cleanup warning filtering in test_uvsim
1a49c3c
to
6ea22be
Compare
@slosar @nmahesh1412 Sorry for the slowness, but I think this is now in a place where it could be merged. You are the two users I know of who are most interested in this, so I wanted to see if either of you wanted to try it out and see if it works for you. |
Hi Bryna, huh, I have completely forgotten about this, it was two years ago! :) In the mean time we have developed our own (harmonic-space) code to do the sims we need to do, so I do not need this feature and not even sure what to test. Perhaps @nmahesh1412 can help. I still think it is probably a good feature to have. |
Description
Relax the requirement that there are always 2 feeds leading to 4 polarizations. Now allow for a single feed. Still require that there are Nfeed^2 polarizations.
Needs changelog and docs updates...
Motivation and Context
Types of changes
Checklist:
For all pull requests:
New feature checklist: