Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a single feed #394

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add support for a single feed #394

wants to merge 4 commits into from

Conversation

slosar
Copy link
Contributor

@slosar slosar commented Mar 30, 2022

Description

Relax the requirement that there are always 2 feeds leading to 4 polarizations. Now allow for a single feed. Still require that there are Nfeed^2 polarizations.

Needs changelog and docs updates...

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Reference simulation update or replacement
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

For all pull requests:

New feature checklist:

  • I have added or updated the docstrings associated with my feature using the numpy docstring format.
  • I have updated the documentation to highlight my new feature (if appropriate).
  • I have added tests to cover my new feature.
  • All new and existing tests pass.
  • I have checked that I reproduce the reference simulations or if there are differences they are explained below (if appropriate). If there are changes that are correct, I will update the reference simulation files after this PR is merged.
  • I have checked (e.g., using the benchmarking tools) that this change does not significantly increase typical runtimes. If it does, I have included a justification in the comments on this PR.
  • I have updated the CHANGELOG.

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a1ee29d) to head (6ea22be).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #394   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2019      2057   +38     
=========================================
+ Hits          2019      2057   +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhazelton bhazelton force-pushed the jones_nfeeds branch 3 times, most recently from f8825c1 to a84733d Compare February 26, 2025 23:34
@bhazelton bhazelton changed the title generalizing jones matrix for Nfeeds=1,2 Add support for a single feed Feb 26, 2025
@bhazelton
Copy link
Member

@slosar @nmahesh1412 Sorry for the slowness, but I think this is now in a place where it could be merged. You are the two users I know of who are most interested in this, so I wanted to see if either of you wanted to try it out and see if it works for you.

@slosar
Copy link
Contributor Author

slosar commented Mar 2, 2025

Hi Bryna, huh, I have completely forgotten about this, it was two years ago! :) In the mean time we have developed our own (harmonic-space) code to do the sims we need to do, so I do not need this feature and not even sure what to test. Perhaps @nmahesh1412 can help. I still think it is probably a good feature to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants