No need to find multiple matches in the same string - fix test case t…

…oo! Fixes #21
Radically · Mar 7, 2021 · 65203ff · 65203ff
1 parent 5fee6eb
commit 65203ff
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/searchalgo/index.ts b/src/searchalgo/index.ts
@@ -95,7 +95,7 @@ export const filterUsingIDCs = (
 ) => {
   const idcs = _idcs.split("").filter((idc) => IDCSet.has(idc));
   if (!idcs) return results;
-  const pattern = RegExp(idcs.join(".*"), "g");
+  const pattern = RegExp(idcs.join(".*"));
   return results.filter((result) => {
     for (let { i } of reverseMapIDSOnly[result]) {
       if (pattern.test(i)) {

diff --git a/src/searchalgo/search.test.ts b/src/searchalgo/search.test.ts
@@ -60,6 +60,7 @@ test("filterUsingIDCs", () => {
   const results = ["與", "义", "凶", "出", "函", "半"];
   expect(filterUsingIDCs(reverseMapCharIDSOnly, results, "⿶")).toEqual([
     "與",
+    "义",
     "凶",
     "函",
   ]);
-Original file line number
+Diff line change
@@ Expand Up / @@ -60,6 +60,7 @@ test("filterUsingIDCs", () => { @@
       const results = ["與", "义", "凶", "出", "函", "半"];
       expect(filterUsingIDCs(reverseMapCharIDSOnly, results, "⿶")).toEqual([
         "與",
+        "义",
         "凶",
         "函",
       ]);
@@ Expand Down @@