Issue 2455 (and also 2519 fixed in passing) #2520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Oh, and I fixed issue #2519 in passing, and (for good measure) updated the top-level |
edeutsch
approved these changes
Jul 10, 2025
sundareswarpullela
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, can someone please review this PR to fix issue 2455? The patch is a bit complex. Basically this patch is attempting to fix the issue that Expand doesn't know how to deal with auxiliary graphs and unbound nodes in TRAPI response knowledge graphs from KPs like Automat. Full details are in the #2455 issue. I've tested on arax.ncats.io/beta using the example queries and using the MWE one-hop query graph provided in the issue. Also reran all the pytest tests for ARAX-expand. So far, so good. But I could use a second pair of eyes to review these diffs for sanity.