-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable gfx950 build target #610
Merged
stanleytsang-amd
merged 27 commits into
ROCm:develop
from
stanleytsang-amd:gfx950-merge
Feb 13, 2025
Merged
Enable gfx950 build target #610
stanleytsang-amd
merged 27 commits into
ROCm:develop
from
stanleytsang-amd:gfx950-merge
Feb 13, 2025
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable gfx94x build targets (ROCm#353) --------- * 5.7 cherry pick - Benchmark perf. improvements for discrete distributions (ROCm#379) * Remove workaround with hipGridDim_x * hipBlockDim_x It makes no difference anymore on ROCm >= 5.5, probably after switching to code object v5. * Use restrict with tables of discrete distributions This change improves performance in device API benchamrks for most engines. --------- --------- Co-authored-by: Stanley Tsang <stanley.tsang@amd.com> Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Eiden Yoshida <eiden.yoshida@amd.com> Co-authored-by: Anton Gorenko <anton@streamhpc.com>
amd-jnovotny
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one minor suggestion.
umfranzw
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.