Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gfx950 build target #610

Merged
merged 27 commits into from
Feb 13, 2025

Conversation

stanleytsang-amd
Copy link
Collaborator

No description provided.

RobsonRLemos and others added 25 commits September 19, 2023 11:37
* Enable gfx94x build targets (ROCm#353)



---------




* 5.7 cherry pick - Benchmark perf. improvements for discrete distributions (ROCm#379)

* Remove workaround with hipGridDim_x * hipBlockDim_x

It makes no difference anymore on ROCm >= 5.5, probably after
switching to code object v5.

* Use restrict with tables of discrete distributions

This change improves performance in device API benchamrks
for most engines.

---------



---------

Co-authored-by: Stanley Tsang <stanley.tsang@amd.com>
Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>
Co-authored-by: Eiden Yoshida <eiden.yoshida@amd.com>
Co-authored-by: Anton Gorenko <anton@streamhpc.com>
@stanleytsang-amd stanleytsang-amd requested a review from a team as a code owner February 13, 2025 21:09
Copy link
Contributor

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one minor suggestion.

Copy link
Collaborator

@umfranzw umfranzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@stanleytsang-amd stanleytsang-amd merged commit 9a2eace into ROCm:develop Feb 13, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants