Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry pick 6.3] Include gfx12 and gfx1151 in default architecture list for rmake.py #579

Merged
merged 4 commits into from
Nov 13, 2024
Merged

[cherry pick 6.3] Include gfx12 and gfx1151 in default architecture list for rmake.py #579

merged 4 commits into from
Nov 13, 2024

Conversation

NguyenNhuDi
Copy link
Collaborator

No description provided.

@NguyenNhuDi NguyenNhuDi changed the base branch from develop to release/rocm-rel-6.3 November 5, 2024 18:45
amd-jnovotny
amd-jnovotny approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of rewording suggestions. O/w looks good from a docs perspective.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
NguyenNhuDi and others added 2 commits November 5, 2024 13:16
@NguyenNhuDi @amd-jnovotny
Update CHANGELOG.md
36c4954 
Co-authored-by: Jeffrey Novotny <[email protected]>
@NguyenNhuDi @amd-jnovotny
Update CHANGELOG.md
7823c44 
Co-authored-by: Jeffrey Novotny <[email protected]>
umfranzw
umfranzw reviewed Nov 5, 2024
View reviewed changes
rmake.py Show resolved Hide resolved
umfranzw
umfranzw approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@umfranzw umfranzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vamovsik vamovsik merged commit 6a6cf6e into ROCm:release/rocm-rel-6.3 Nov 13, 2024
14 of 15 checks passed
@NguyenNhuDi NguyenNhuDi deleted the zenguyen/rmake-support-6.3 branch November 21, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amd-jnovotny amd-jnovotny amd-jnovotny approved these changes

@umfranzw umfranzw umfranzw approved these changes

@stanleytsang-amd stanleytsang-amd Awaiting requested review from stanleytsang-amd stanleytsang-amd is a code owner

@RobsonRLemos RobsonRLemos Awaiting requested review from RobsonRLemos RobsonRLemos is a code owner

@lawruble13 lawruble13 Awaiting requested review from lawruble13 lawruble13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NguyenNhuDi @umfranzw @amd-jnovotny @vamovsik