Develop stream 2024-10-28 #574
Merged
+261
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naraenda
requested review from
a team,
stanleytsang-amd,
umfranzw,
RobsonRLemos and
lawruble13
as code owners
|
Thank you for the grammar and punctuation fixes! |
amd-jnovotny
approved these changes
Oct 28, 2024
|
The component owners should review the other changes. My approval only applies to the docs updates. |
stanleytsang-amd
requested changes
Nov 20, 2024
CHANGELOG.md
Outdated
| @@ -16,12 +16,13 @@ Documentation for rocRAND is available at | |||
| ### Changed | |||
|
|
|||
| * `rocrand_discrete` for MTGP32, LFSR113 and ThreeFry generators now uses the alias method, which is faster than binary search in CDF. | |||
| * Removed TBB dependency for multi-core processing of host-side generation. | |||
There was a problem hiding this comment.
This PR will be going in for ROCm 6.4 - please add a new release entry in the changelog, and also bump the version number in CMakeLists.txt to match. Thanks!
There was a problem hiding this comment.
Done, had to rebase as well.
ci: set up sccache See merge request amd/libraries/rocRAND!345
CI: Run statistical tests Closes ROCm#224 See merge request amd/libraries/rocRAND!344
Binaries of tests and benchmarks are large with static linking, packing takes about 12 minutes (though these packages are not used).
The host-side generators are only really provided for cuRAND compatibility. Their performance is not really of interest, and removing the TBB dependency eases packaging and maintenance.
Resolve "CPack step takes a long time" Closes ROCm#372 See merge request amd/libraries/rocRAND!348
Resolve "Remove TBB dependency" Closes ROCm#378 See merge request amd/libraries/rocRAND!350
…lop_stream' Resolve "Add small examples to API documentation" Closes ROCm#370 See merge request amd/libraries/rocRAND!351
docs(api-reference/cpp-api): improve grammar and punctuation Co-authored-by: Jeffrey Novotny <[email protected]>
Naraenda
force-pushed
the
develop_stream_20241028
branch
from
fd58a5a to
0c02d35
Compare
stanleytsang-amd
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following: