Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Smoke Test][rocRAND] Ported over rtest.py from rocPRIM and added smoke test option #573

Merged
merged 14 commits into from
Nov 13, 2024
Merged

[Smoke Test][rocRAND] Ported over rtest.py from rocPRIM and added smoke test option #573

merged 14 commits into from
Nov 13, 2024

Conversation

NguyenNhuDi
Copy link
Collaborator

No description provided.

@NguyenNhuDi NguyenNhuDi requested a review from a team as a code owner October 23, 2024 23:07
amd-jnovotny
amd-jnovotny approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small changes for the changelog. Docs look good otherwise.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
amd-jnovotny
amd-jnovotny approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the changelog using the proper format. I just have a few editorial suggestions for you. Otherwise, the changelog looks good from a docs perspective.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
NguyenNhuDi and others added 2 commits November 4, 2024 11:04
@NguyenNhuDi @amd-jnovotny
Update CHANGELOG.md
a7ee51e 
Co-authored-by: Jeffrey Novotny <[email protected]>
@NguyenNhuDi @amd-jnovotny
Update CHANGELOG.md
73d37ad 
Co-authored-by: Jeffrey Novotny <[email protected]>
@NguyenNhuDi NguyenNhuDi changed the title Ported over rtest.py from rocPRIM and added smoke test option [Smoke Test][rocRAND] Ported over rtest.py from rocPRIM and added smoke test option Nov 5, 2024
This was referenced Nov 5, 2024
Merged
Merged
umfranzw
umfranzw approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@umfranzw umfranzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. The CI build failures look unrelated to this change.

@NguyenNhuDi NguyenNhuDi merged commit 22c4ab0 into ROCm:develop Nov 13, 2024
19 of 23 checks passed
@NguyenNhuDi NguyenNhuDi deleted the zenguyen/smoke-test-impl branch November 21, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amd-jnovotny amd-jnovotny amd-jnovotny approved these changes

@umfranzw umfranzw umfranzw approved these changes

@stanleytsang-amd stanleytsang-amd Awaiting requested review from stanleytsang-amd stanleytsang-amd is a code owner

@RobsonRLemos RobsonRLemos Awaiting requested review from RobsonRLemos RobsonRLemos is a code owner

@lawruble13 lawruble13 Awaiting requested review from lawruble13 lawruble13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NguyenNhuDi @umfranzw @amd-jnovotny