Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Experimental] Support on arbitrary M & K for siwzzle-A #1521

Open
wants to merge 7 commits into
base: stable3
Choose a base branch
from
Open

[Experimental] Support on arbitrary M & K for siwzzle-A #1521

wants to merge 7 commits into from
+225 −35

Conversation

Serge45
Copy link
Collaborator

@Serge45 Serge45 commented Jan 7, 2025

Implemented

  • removed the restriction of M and K, now the kernels assume tensor A is properly padded
  • CPU implementation of padding op
  • auto-padding for tensilelite client and hipblaslt-bench
  • samples for weight padding.

@Serge45 Serge45 force-pushed the stable3/swizzle-padding branch from 95c2450 to 3f3ebf6 Compare January 7, 2025 13:41
@Serge45 Serge45 mentioned this pull request Jan 16, 2025
Merged
@jichangjichang jichangjichang force-pushed the stable3 branch 2 times, most recently from 9a33657 to 75f5cdf Compare January 20, 2025 07:20
@Serge45 Serge45 force-pushed the stable3/swizzle-padding branch from 63114c7 to d21a7e6 Compare January 20, 2025 08:18
jichangjichang
jichangjichang reviewed Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@jichangjichang jichangjichang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some odd size test items into gtest?

@Serge45 Serge45 requested a review from a team as a code owner January 22, 2025 07:42
jichangjichang
jichangjichang reviewed Jan 22, 2025
View reviewed changes
library/include/hipblaslt.h Outdated
* Note that for this order, the number of columns(rows) of the tensor has to be multiple of 16(32) or
* pre-padded to 16(32).
*/
HIPBLASLT_ORDER_COL16_4R8 = 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shift the num to a larger value for hipblaslt specific enum type
ex: HIPBLASLT_MATMUL_DESC_COMPUTE_INPUT_TYPE_A_EXT = 100,

@Serge45 Serge45 force-pushed the stable3/swizzle-padding branch from 28b5c44 to d77b0b4 Compare January 22, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichangjichang jichangjichang jichangjichang left review comments

@KKyang KKyang Awaiting requested review from KKyang KKyang is a code owner

@vin-huang vin-huang Awaiting requested review from vin-huang vin-huang is a code owner

@imcarsonliao imcarsonliao Awaiting requested review from imcarsonliao imcarsonliao is a code owner

@hcman2 hcman2 Awaiting requested review from hcman2 hcman2 is a code owner

@Jinp800125 Jinp800125 Awaiting requested review from Jinp800125 Jinp800125 is a code owner

@TonyYHsieh TonyYHsieh Awaiting requested review from TonyYHsieh TonyYHsieh is a code owner

@solaslin solaslin Awaiting requested review from solaslin solaslin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Serge45 @jichangjichang