Code object compression via bundling #2054
Open
+469
−322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstefanuk
requested review from
babakpst,
yoichiyoshida,
bragadeesh and
AlexBrownAMD
as code owners
ellosel
reviewed
Nov 21, 2024
ellosel
reviewed
Nov 21, 2024
TorreZuk
approved these changes
Nov 26, 2024
fix: lint error 1 feat: add hsaco compression fix: remove unused and debug code refactor: move build commands to module
chore: type-hints, doc-comments and errors fix: static tox errors chore: type-hints, doc-comments and errors fix: static tox errors fix: static tox errors fix: missing param in benchmark client fix: delete irrelevant files fix: don't compress source kernels fix: tox static errors fix: tox errors 2 fix: bad exception creating co filenames
bstefanuk
force-pushed
the
bundle-compress-co-files
branch
from
334b57a
to
0e8f993
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds a compression layer to all final code objects, thereby generating smaller libraries at the expense of build time. Includes minor refactoring.
Outcomes:
getAssemblyCodeObjectFileshas been renamed tobuildAssemblyCodeObjectFilesto match the name of source kernel functions.Compression ratio for gfx900: 2.66
Compression ratio for gfx90a: 3.74
Testing and Environment:
Docker: Ubuntu 24.04, ROCm 6.4 RC stack, AMD clang version 18.0.0, AMD clang-offload-bundler version 18.0.0
Tested with rocBLAS test client