Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIPIFY][#1841][build] Add execution permission to hipify-perl #1853

Merged
merged 2 commits into from
Feb 10, 2025
Merged

[HIPIFY][#1841][build] Add execution permission to hipify-perl #1853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa735ed
[HIPIFY][#1841][build] Add execution permition to `hipify-perl`
emankov Feb 6, 2025
fa6306d
[HIPIFY][doc][tests] `Python 3.13.2` is the latest Python version sup…
emankov Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ if (NOT HIPIFY_CLANG_TESTS_ONLY)
install(
DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/bin
DESTINATION .
PATTERN "hipify-perl"
PATTERN "*.sh"
PATTERN "findcode.sh" EXCLUDE
PATTERN "findcode_headers.sh" EXCLUDE
Expand All @@ -192,6 +191,7 @@ if (NOT HIPIFY_CLANG_TESTS_ONLY)
set(HIPIFY_LIBEXEC_INSTALL_PATH "${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBEXECDIR}/hipify")

install(
PROGRAMS ${CMAKE_CURRENT_SOURCE_DIR}/bin/hipify-perl
PROGRAMS ${CMAKE_CURRENT_SOURCE_DIR}/bin/findcode.sh
PROGRAMS ${CMAKE_CURRENT_SOURCE_DIR}/bin/findcode_headers.sh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

findcode.sh, findcode_headers.sh, ... are excluded in the old code. do we need to install it now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK they are still being shipped in packages, but even if that is not so now, their removal is not the point of this PR.

PROGRAMS ${CMAKE_CURRENT_SOURCE_DIR}/bin/findcode_sources.sh
Expand Down
12 changes: 6 additions & 6 deletions docs/building/building-hipify.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ Minimum build system requirements for the above configurations:

Recommended build system requirements:

* CMake 3.31.2, GNU C/C++ 13.2, Python 3.13.1.
* CMake 3.31.2, GNU C/C++ 13.2, Python 3.13.2.

Here's how to build ``hipify-clang`` with testing support on ``Ubuntu 23.10.01``:

Expand Down Expand Up @@ -338,7 +338,7 @@ The corresponding successful output is:
-- - Binary path : /usr/llvm/19.1.7/dist/bin
-- Linker detection: GNU ld
-- ---- The below configuring for hipify-clang testing only ----
-- Found Python: /usr/bin/python3.13 (found suitable version "3.13.1", required range is "3.0...3.14") found components: Interpreter
-- Found Python: /usr/bin/python3.13 (found suitable version "3.13.2", required range is "3.0...3.14") found components: Interpreter
-- Found lit: /usr/local/bin/lit
-- Found FileCheck: /GIT/LLVM/trunk/dist/FileCheck
-- Initial CUDA to configure:
Expand Down Expand Up @@ -376,7 +376,7 @@ The corresponding successful output is:
x86_64 - Platform architecture
Linux 6.5.0-15-generic - Platform OS
64 - hipify-clang binary bitness
64 - python 3.13.1 binary bitness
64 - python 3.13.2 binary bitness
===============================================================
-- Testing: 106 tests, 12 threads --
Testing Time: 6.91s
Expand Down Expand Up @@ -471,13 +471,13 @@ Tested configurations:
- ``8.0.5 - 9.7.0``
- ``2019.16.11.42, 2022.17.12.3``
- ``3.31.2``
- ``3.13.1``
- ``3.13.2``
* - ``19.1.0 - 19.1.7``
- ``7.0 - 12.6.3``
- ``8.0.5 - 9.7.0``
- ``2019.16.11.42, 2022.17.12.3``
- ``3.31.2``
- ``3.13.1``
- ``3.13.2``

:sup:`5` LLVM 14.x.x is the latest major release supporting Visual Studio 2017.

Expand Down Expand Up @@ -538,7 +538,7 @@ The corresponding successful output is:
-- - LLVM Include path : D:/LLVM/19.1.7/dist/include
-- - Binary path : D:/LLVM/19.1.7/dist/bin
-- ---- The below configuring for hipify-clang testing only ----
-- Found Python: C:/Users/TT/AppData/Local/Programs/Python/Python313/python.exe (found suitable version "3.13.1", required range is "3.0...3.14") found components: Interpreter
-- Found Python: C:/Users/TT/AppData/Local/Programs/Python/Python313/python.exe (found suitable version "3.13.2", required range is "3.0...3.14") found components: Interpreter
-- Found lit: C:/Users/TT/AppData/Local/Programs/Python/Python313/Scripts/lit.exe
-- Found FileCheck: D:/LLVM/19.1.7/dist/bin/FileCheck.exe
-- Initial CUDA to configure:
Expand Down
Loading