Skip to content

static-test/vera++: reduce linelength false positives #21364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kfessel wants to merge 3 commits into from
Closed

static-test/vera++: reduce linelength false positives #21364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe9515d
static-test/vera++: reduce linelength false positives
kfessel Apr 4, 2025
6c1c704
REMOVE ME
kfessel Apr 4, 2025
d739903
remove this commit
kfessel Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions .github/workflows/check-commits.yml
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions .github/workflows/check-labels.yml
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions .github/workflows/labeler.yml
View file
Open in desktop

This file was deleted.

178 changes: 0 additions & 178 deletions .github/workflows/release-test.yml
View file
Open in desktop

This file was deleted.

17 changes: 14 additions & 3 deletions dist/tools/vera++/check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ CURDIR=$(cd "$(dirname "$0")" && pwd)
: "${QUIET:=0}"
: "${WARNING:=1}"

BASE_BRANCH=""
. "$RIOTBASE"/dist/tools/ci/changed_files.sh
. "$RIOTBASE"/dist/tools/ci/github_annotate.sh
# tests/pkg/utensor/models/deep_mlp_weight.hpp is an auto-generated file
Expand Down Expand Up @@ -48,9 +49,19 @@ if github_annotate_is_on; then
LINENUM=$(echo "${line}" | cut -d: -f2)
DETAILS=$(echo "${line}" | cut -d: -f3- |
sed -e 's/^[ \t]*//' -e 's/[ \t]*$//')

# parse if warning (errors don't have a label)
if echo "$DETAILS" | grep -q "^warning: "; then
if
{
echo "$DETAILS" | grep -q "longer than 100 characters" &&
inline_comment=$(sed -n "${LINENUM}p" "${FILENAME}" | sed -n '/\/\*\*</p') &&
http_comment=$(sed -n "${LINENUM}p" "${FILENAME}" | sed -n '/^\s*[*/].*https*:\/\//p') &&
[ -n "${inline_comment}" -o -n "${http_comment}" ]
}
then
# ignore inline comments exceeding line length
# ignore lines containing http:// or https:// exceeding line length
true
elif echo "$DETAILS" | grep -q "^warning: "; then
# parse if warning (errors don't have a label)
DETAILS=$(echo "$DETAILS" | sed 's/^warning: //')
github_annotate_warning "$FILENAME" "$LINENUM" "$DETAILS"
else
Expand Down
Loading