Update external charts via Makefile #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blootsvoets would you be able to look into this? |
3 tasks
|
@keyvaann I pushed some commits here, the script is now updated to include the new charts and works. |
This would trigger if an external chart is added to the main branch without a simple way to update it
|
@Bdegraaf1234 Thanks! Please review this so we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the Makefile to make it easier to update the dependencies.
@blootsvoets could you please tell me or update the branch with changes needed to fix the charts for our internal use?
With this changes it's now possible to update the charts individually via
make update-cert-managerfor example or all charts at once withmake deps