-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update helm charts for Sentry configuration #311
base: main
Are you sure you want to change the base?
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
c520c7a
to
2dcd892
Compare
*/}} | ||
{{- define "app-config.sentryName" -}} | ||
{{- if .Values.sentry.service.name }} | ||
{{- printf "%s" .Values.sentry.service.name -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain why these should be configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those two don't need to be configurable, I made it that way just to give more flexibility in how the service names are displayed in Sentry as an extra option. I can remove that, if this is problematic or just not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not problematic and in general it's good to have the flexibility. However this adds a bit of complexity to the charts and since I haven't used the Sentry interface I don't know how much benefit this brings. You can decide on this.
Implements RB-152
Some of the components have been enhanced with Sentry monitoring. This PR: