Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor postgresql and timescaledb charts #306

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

pvannierop
Copy link
Collaborator

Problem

At the moment timescale db functionality is broken:

  1. No actual timescaledb image is used.
  2. Using the POSTGRES_MULTIPLE_DATABASES mechanism for timescaledb does not work because the init script mechanism breaks the init scripts of the timescaledb docker image

Solution

This PR will create new radar-specific charts for postgres and timescaledb that replace platform logic previously set in the RADAR-Kubernetes (helmfile) layer, specifically the docker image (+version) and initialization logic.

Note

The timescaledb image does NOT support initalization of multiple databases. This restriction will be included in a new version of RADAR-Kubernetes.

@pvannierop pvannierop requested a review from keyvaann December 18, 2024 11:17
@pvannierop pvannierop self-assigned this Dec 18, 2024
Copy link

github-actions bot commented Dec 18, 2024

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

@pvannierop pvannierop force-pushed the refactor/radar-postgres branch from 492487c to 0980d26 Compare December 18, 2024 13:09
@pvannierop pvannierop force-pushed the refactor/radar-postgres branch from 0980d26 to 1737576 Compare December 18, 2024 13:23
Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvannierop pvannierop force-pushed the refactor/radar-postgres branch from 01402ec to 9a03f01 Compare December 18, 2024 13:50
@pvannierop pvannierop merged commit 9bed521 into main Dec 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants