Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rest-sources-backend] Update configmap variables #282

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[rest-sources-backend] Update configmap variables #282

wants to merge 3 commits into from

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Oct 21, 2024

Description of the change

  • Updates authorizer.yml configmap to allow setting of public key urls for token verification (other than MP)
  • Updates chart to allow setting of jwksUrls and authUri for authentication

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [<name_of_the_chart>])

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

yatharthranjan
yatharthranjan approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

charts/radar-rest-sources-backend/README.md
@@ -85,6 +85,8 @@ A Helm chart for the backend application of RADAR-base Rest Sources Authorizer
| serverName | string | `"localhost"` | Resolvable server name, needed to find the advertised URL and callback URL |
| managementportal_url | string | `"http://management-portal:8080/managementportal"` | URL of the Management Portal |
| client_secret | string | `"secret"` | OAuth2 client secret of the radar-rest-sources-backend client from Management Portal |
| public_key_endpoints | list | `[]` | List of public key endpoints for token verification |
| auth_url | string | `"http://management-portal:8080/managementportal/oauth/token"` | Auth url for MP client |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change the default to hydra?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatharthranjan yatharthranjan yatharthranjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpgxvii @yatharthranjan