Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix versions of external charts #230

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Fix versions of external charts #230

merged 2 commits into from
Jul 24, 2024

Conversation

keyvaann
Copy link
Collaborator

Graylog had to be reverted back to older version that was still using Elasticsearch to avoid migration to Opensearch.
Updated version of a few other charts to latest version.

@keyvaann keyvaann requested a review from pvannierop July 24, 2024 07:35
Copy link
Collaborator

@Bdegraaf1234 Bdegraaf1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I made a comment somewhere, could be nothing but I am not well versed enough to know for sure

@@ -114,12 +123,19 @@ The order in which this function returns a secret password:
{{- $subStr := list (lower (randAlpha 1)) (randNumeric 1) (upper (randAlpha 1)) | join "_" }}
{{- $password = randAscii $passwordLength }}
{{- $password = regexReplaceAllLiteral "\\W" $password "@" | substr 5 $passwordLength }}
{{- $password = printf "%s%s" $subStr $password | toString | shuffle | b64enc | quote }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few of these sprinkled around. It's definitely out of my comfort zone, but these are not customizations that were previously added by us?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I don't think we have customized these values. The external folder is meant to be a mirror.

@keyvaann keyvaann merged commit b2051fc into main Jul 24, 2024
2 checks passed
@keyvaann keyvaann deleted the fix-external-charts branch July 24, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants