Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data-dashboard-backend] Add classname to Ingress #211

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[data-dashboard-backend] Add classname to Ingress #211

merged 1 commit into from
Jul 3, 2024

Conversation

pvannierop
Copy link
Collaborator

Ingress was broken because of missing Ingress class name

@pvannierop pvannierop requested a review from keyvaann July 3, 2024 07:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

keyvaann
keyvaann approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyvaann keyvaann merged commit 8e1108b into main Jul 3, 2024
4 checks passed
@keyvaann keyvaann deleted the fix-dashboard-backend-ingress branch July 3, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyvaann keyvaann keyvaann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvannierop @keyvaann