Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitattribute to help with correct helm-docs formatting #210

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

Bdegraaf1234
Copy link
Collaborator

Description of the change

Add a gitattribute to ensure automatic normalization of line endings for new files.

Benefits

Prevent files being checked in with the wrong line-endings, so that everyone can count on consistent line-endings in the whole repo.

Possible drawbacks

Applicable issues

Additional information

This was done in an effort to improve the contributor experience on windows, as troubles with lin-endings there cause failing CI jobs. It is a part of this step by step guide to changing the line-endings in the repo locally.

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [<name_of_the_chart>])

@Bdegraaf1234 Bdegraaf1234 self-assigned this Jul 1, 2024
@pvannierop pvannierop requested review from keyvaann and pvannierop July 2, 2024 05:28
Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyvaann keyvaann merged commit eeefbc1 into main Jul 2, 2024
1 check passed
@keyvaann keyvaann deleted the update-ci branch July 2, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants