Fix description of kafka_num_brokers value #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
keyvaann
reviewed
Jun 21, 2024
charts/radar-s3-connector/Chart.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: v2 | |||
| appVersion: "7.6.0-hotfix" | |||
| description: A Helm chart for RADAR-base s3 connector. This connector uses Confluent s3 connector with a custom data transformers. These configurations enable a sink connector. See full list of properties here https://docs.confluent.io/kafka-connect-s3-sink/current/configuration_options.html#s3-configuration-options | |||
| name: radar-s3-connector | |||
| version: 0.3.2 | |||
| version: 0.4.0 | |||
There was a problem hiding this comment.
Minor version increases are better used bigger updates
There was a problem hiding this comment.
I have put the version at 0.3.3.
pvannierop
force-pushed
the
fix-s3-connector-num-kafka-brokers
branch
from
5834832 to
691b983
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See subject. Documentation was missing on this property.